Don't monitor the filesystem during "pub build".

Don't monitor the filesystem during "pub build".

BUG=13848
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29406

[nweiz, 2013-10-25 03:15:11]

I'm assigning this (and potentially more CLs tonight) to Alan because I assume
Bob will want some catchup time tomorrow. Bob, if you want to take it, feel
free.

[Bob Nystrom, 2013-10-25 23:04:16]

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/barback.dart (right):

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:124: // If any errors get emitted
either by barback or by the server, including
Is this right? I think we'd want to keep it running so we can show as many
errors as possible to the user and then exit when the build is done.

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:125: // non-programmatic barback
errors, they should take down the whole program.
Long line.

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:132: if (!completer.isCompleted)
completer.completeError(error, stackTrace);
Long line.

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:135: if (!completer.isCompleted)
completer.completeError(error, stackTrace);
Long line.

[nweiz, 2013-10-28 22:43:35]

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/barback.dart (right):

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:124: // If any errors get emitted
either by barback or by the server, including
On 2013/10/25 23:04:16, Bob Nystrom wrote:
> Is this right? I think we'd want to keep it running so we can show as many
> errors as possible to the user and then exit when the build is done.

It's tricky. Since these handlers are running while transformers are being
loaded, and those transformers may be transformed by other transformers, the
optimal point to give up after printing the most available errors isn't always
going to be clear. We don't want to end up presenting the user with an isolate
load error caused by trying to load a broken transformer.

This is out of scope for this patch, but I've filed issue 14552 to track it.

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:125: // non-programmatic barback
errors, they should take down the whole program.
On 2013/10/25 23:04:16, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:132: if (!completer.isCompleted)
completer.completeError(error, stackTrace);
On 2013/10/25 23:04:16, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/43093002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:135: if (!completer.isCompleted)
completer.completeError(error, stackTrace);
On 2013/10/25 23:04:16, Bob Nystrom wrote:
> Long line.

Done.

[Bob Nystrom, 2013-10-28 22:59:11]

LGTM.

[nweiz, 2013-10-29 00:13:29]

Committed patchset #2 manually as r29406 (presubmit successful).