Issue 430803003: Add timestamps to integration test output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430803003: Add timestamps to integration test output. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add timestamps to integration test output. This should aid in debugging buildbot failures. TBR=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38743

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	pkg/analysis_server/test/integration/integration_tests.dart	View		2 chunks	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 manually as r38743 (presubmit successful).

6 years, 4 months ago (2014-07-30 18:20:36 UTC) #1

scheglov

6 years, 4 months ago (2014-07-30 18:46:16 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/430803003/diff/1/pkg/analysis_server/test/int...
File pkg/analysis_server/test/integration/integration_tests.dart (right):

https://codereview.chromium.org/430803003/diff/1/pkg/analysis_server/test/int...
pkg/analysis_server/test/integration/integration_tests.dart:713:
_time.frequency.toDouble();
Do you need toDouble() here?
3 / 2 already gives 1.5

Expand Messages | Collapse Messages