Issue 43073002: Fix Function.apply() + call() + noSuchMethod() in dart2js

Issue 43073002: Fix Function.apply() + call() + noSuchMethod() in dart2js (Closed)

Created:
7 years, 1 month ago by justinfagnani

Modified:
7 years, 1 month ago

Reviewers:
ahe, sra, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Function.apply() + call() + noSuchMethod() in dart2js BUG=https://code.google.com/p/dart/issues/detail?id=14288 R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=29287

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
	M	sdk/lib/_internal/lib/js_helper.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	A +	tests/language/call_with_no_such_method_test.dart	View		1 chunk	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/43073002/diff/1/sdk/lib/_internal/lib/js_helper.dart File sdk/lib/_internal/lib/js_helper.dart (left): https://codereview.chromium.org/43073002/diff/1/sdk/lib/_internal/lib/js_helper.dart#oldcode718 sdk/lib/_internal/lib/js_helper.dart:718: namedArguments == null ? null : namedArguments.keys.toList())); Seems like ...

7 years, 1 month ago (2013-10-25 13:55:50 UTC) #2

justinfagnani

https://chromiumcodereview.appspot.com/43073002/diff/1/sdk/lib/_internal/lib/js_helper.dart File sdk/lib/_internal/lib/js_helper.dart (left): https://chromiumcodereview.appspot.com/43073002/diff/1/sdk/lib/_internal/lib/js_helper.dart#oldcode718 sdk/lib/_internal/lib/js_helper.dart:718: namedArguments == null ? null : namedArguments.keys.toList())); On 2013/10/25 ...

7 years, 1 month ago (2013-10-25 18:43:28 UTC) #3

justinfagnani

Committed patchset #2 manually as r29287 (presubmit successful).

7 years, 1 month ago (2013-10-25 20:56:57 UTC) #5

ahe

7 years, 1 month ago (2013-10-29 17:02:30 UTC) #6

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/43073002/diff/1/sdk/lib/_internal/lib/...
File sdk/lib/_internal/lib/js_helper.dart (left):

https://chromiumcodereview.appspot.com/43073002/diff/1/sdk/lib/_internal/lib/...
sdk/lib/_internal/lib/js_helper.dart:718: namedArguments == null ? null :
namedArguments.keys.toList()));
On 2013/10/25 18:43:29, justinfagnani wrote:
> On 2013/10/25 13:55:50, ahe wrote:
> > Seems like the problem is really here. This should be:
> > 
> > namedArguments == null ? [] : namedArguments.keys.toList()
> 
> Could be either way, the fix in the constructor prevents future callers from
> breaking too. Either way is fine w/ me. Done.

Fixing the constructor means that there is a redundant check when it is called
from generated code.

Expand Messages | Collapse Messages