Issue 430343002: Actually release source_maps 0.10.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430343002: Actually release source_maps 0.10.0. (Closed)

Created:
6 years, 4 months ago by nweiz

Modified:
6 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Actually release source_maps 0.10.0. BUG=19930 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38813

Patch Set 2 : Code review changes #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	pkg/source_maps/CHANGELOG.md	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	pkg/source_maps/pubspec.yaml	View	1	1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/430343002/diff/1/pkg/source_maps/pubspec.yaml File pkg/source_maps/pubspec.yaml (right): https://codereview.chromium.org/430343002/diff/1/pkg/source_maps/pubspec.yaml#newcode2 pkg/source_maps/pubspec.yaml:2: nit, remove empty line?

6 years, 4 months ago (2014-07-31 22:38:57 UTC) #2

nweiz

https://codereview.chromium.org/430343002/diff/1/pkg/source_maps/pubspec.yaml File pkg/source_maps/pubspec.yaml (right): https://codereview.chromium.org/430343002/diff/1/pkg/source_maps/pubspec.yaml#newcode2 pkg/source_maps/pubspec.yaml:2: On 2014/07/31 22:38:57, Siggi Cherem (dart-lang) wrote: > nit, ...

6 years, 4 months ago (2014-08-01 00:39:19 UTC) #4

nweiz

6 years, 4 months ago (2014-08-01 00:39:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r38813 (presubmit successful).

Expand Messages | Collapse Messages

Issue 430343002: Actually release source_maps 0.10.0. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages