Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 429293002: Add request tracing to Observatory: (Closed)

Created:
6 years, 4 months ago by turnidge
Modified:
6 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Add request tracing to Observatory: URL---trace=on turns tracing on URL---trace=off turns tracing off BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39011

Patch Set 1 #

Patch Set 2 : #

Total comments: 9

Patch Set 3 : code review fixes #

Patch Set 4 : post confusion clarity #

Patch Set 5 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16110 lines, -11442 lines) Patch
M runtime/bin/vmservice/observatory/deploy.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 2 3 4 58 chunks +1246 lines, -8 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 589 chunks +6584 lines, -5678 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 2 3 4 58 chunks +1246 lines, -8 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 589 chunks +6584 lines, -5678 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/css/shared.css View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/service_view.html View 1 2 3 4 1 chunk +91 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/README.md View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/bower.json View 1 2 3 4 1 chunk +4 lines, -16 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/build.log View 1 2 3 4 1 chunk +16 lines, -12 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/layout.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/polymer.js View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log View 1 2 3 4 1 chunk +29 lines, -23 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/app.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/service.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/app/application.dart View 1 2 3 3 chunks +22 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/css/shared.css View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/script_ref.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart View 1 2 3 2 chunks +55 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_view.html View 1 2 3 1 chunk +91 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/stack_frame.dart View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/lib/tracer.dart View 1 2 3 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
turnidge
6 years, 4 months ago (2014-07-30 18:11:27 UTC) #1
Cutch
https://codereview.chromium.org/429293002/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart File runtime/bin/vmservice/client/lib/src/app/application.dart (right): https://codereview.chromium.org/429293002/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart#newcode177 runtime/bin/vmservice/client/lib/src/app/application.dart:177: print("ADDING TraceView"); remove (or turn into log call) before ...
6 years, 4 months ago (2014-07-30 18:20:46 UTC) #2
Cutch
one more note https://codereview.chromium.org/429293002/diff/20001/runtime/bin/vmservice/client/lib/src/app/location_manager.dart File runtime/bin/vmservice/client/lib/src/app/location_manager.dart (right): https://codereview.chromium.org/429293002/diff/20001/runtime/bin/vmservice/client/lib/src/app/location_manager.dart#newcode56 runtime/bin/vmservice/client/lib/src/app/location_manager.dart:56: url = chunks[0]; Does this support ...
6 years, 4 months ago (2014-07-30 18:47:18 UTC) #3
turnidge
https://codereview.chromium.org/429293002/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart File runtime/bin/vmservice/client/lib/src/app/application.dart (right): https://codereview.chromium.org/429293002/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart#newcode177 runtime/bin/vmservice/client/lib/src/app/application.dart:177: print("ADDING TraceView"); On 2014/07/30 18:20:46, Cutch wrote: > remove ...
6 years, 4 months ago (2014-07-30 19:28:16 UTC) #4
Cutch
lgtm https://codereview.chromium.org/429293002/diff/20001/runtime/bin/vmservice/client/lib/src/app/location_manager.dart File runtime/bin/vmservice/client/lib/src/app/location_manager.dart (right): https://codereview.chromium.org/429293002/diff/20001/runtime/bin/vmservice/client/lib/src/app/location_manager.dart#newcode56 runtime/bin/vmservice/client/lib/src/app/location_manager.dart:56: url = chunks[0]; On 2014/07/30 19:28:15, turnidge wrote: ...
6 years, 4 months ago (2014-07-30 21:58:39 UTC) #5
koda
This only traces responses from synchronous requests, right? It would be great to also trace ...
6 years, 4 months ago (2014-08-06 17:47:05 UTC) #6
turnidge
6 years, 4 months ago (2014-08-07 22:35:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 manually as 39011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698