Issue 429013002: Make Dart_LoadLibrary and Dart_LoadSource take line and column offsets like Dart_LoadScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 429013002: Make Dart_LoadLibrary and Dart_LoadSource take line and column offsets like Dart_LoadScript. (Closed)

Created:
6 years, 4 months ago by rmacnak

Modified:
6 years, 4 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, vsm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make Dart_LoadLibrary and Dart_LoadSource take line and column offsets like Dart_LoadScript. BUG=http://dartbug.com/13460 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=38801

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -70 lines)			Patch
M	runtime/bin/builtin.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice_impl.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3	8 chunks	+28 lines, -6 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	23 chunks	+48 lines, -48 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

rmacnak

On 2014/07/31 21:12:21, hausner wrote: > LGTM but I'd suspect you also need to change ...

6 years, 4 months ago (2014-07-31 21:14:25 UTC) #3

rmacnak

6 years, 4 months ago (2014-07-31 21:25:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r38801 (presubmit successful).