Issue 428993002: Revert async changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428993002: Revert async changes. (Closed)

Created:
6 years, 4 months ago by Michael Lippautz (Google)

Modified:
6 years, 4 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert async changes. Revert "Transform functions marked as async" This reverts commit 79cbaaf60143babcb29bb0ed74a0da87fd998c39. Revert "Fix snapshot test" This reverts commit ee892aa105daccc74c734eb18934814b76a415bb. BUG= Committed: https://code.google.com/p/dart/source/detail?r=38690

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -429 lines)			Patch
M	runtime/vm/ast.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	6 chunks	+0 lines, -20 lines	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+1 line, -13 lines	0 comments	Download
M	runtime/vm/parser.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/parser.cc	View	18 chunks	+3 lines, -246 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	tests/language/async_test.dart	View	1 chunk	+0 lines, -121 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/standalone/issue14236_test.dart	View	Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Lippautz (Google)

TBR async is not a regular keyword. Need to figure out how the type of ...

6 years, 4 months ago (2014-07-29 18:42:25 UTC) #1

Michael Lippautz (Google)

Committed patchset #1 manually as r38690 (presubmit successful).

6 years, 4 months ago (2014-07-29 18:43:10 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages