Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 428613002: Enable using the service library from dart:io applications. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Enable using the service library from dart:io applications. Handle WebSocket differences between dart:html and dart:io. Create simple command-line shell as an example. This will enable standalone unit tests that use the service library. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38655

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10396 lines, -11583 lines) Patch
A runtime/bin/vmservice/client/bin/shell.dart View 1 2 4 1 chunk +35 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 618 chunks +5125 lines, -5642 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 618 chunks +5125 lines, -5642 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/service_common.dart View 1 4 9 chunks +37 lines, -68 lines 0 comments Download
M runtime/bin/vmservice/client/lib/service_html.dart View 1 2 3 4 1 chunk +24 lines, -231 lines 0 comments Download
A runtime/bin/vmservice/client/lib/service_io.dart View 1 4 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
6 years, 4 months ago (2014-07-28 16:41:03 UTC) #1
Cutch
lgtm after you test that you can do the following: 1) $ dart --observe ...
6 years, 4 months ago (2014-07-28 20:46:14 UTC) #2
koda
On 2014/07/28 20:46:14, Cutch wrote: > lgtm after you test that you can do the ...
6 years, 4 months ago (2014-07-28 23:08:21 UTC) #3
koda
https://codereview.chromium.org/428613002/diff/40001/runtime/bin/vmservice/client/lib/service_html.dart File runtime/bin/vmservice/client/lib/service_html.dart (right): https://codereview.chromium.org/428613002/diff/40001/runtime/bin/vmservice/client/lib/service_html.dart#newcode24 runtime/bin/vmservice/client/lib/service_html.dart:24: print("connect"); On 2014/07/28 20:46:14, Cutch wrote: > remove debug ...
6 years, 4 months ago (2014-07-28 23:08:30 UTC) #4
koda
6 years, 4 months ago (2014-07-29 00:44:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r38655 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698