refactor code completion to allow for multiple suggestion computers

refactor code completion to allow for multiple suggestion computers

BUG=
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38787

[scheglov, 2014-07-30 22:44:24]

LGTM

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_completion.dart:56: Response
processRequest(Request request) {
`completion.getSuggestions`

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/completion/top_level_computer.dart (right):

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/top_level_computer.dart:10: import
'package:analysis_services/completion/completion_computer.dart';
Use Cmd+1  |  Sort unit/class members :-)

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/test/c...
File pkg/analysis_services/test/completion/completion_computer_test.dart
(right):

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/test/c...
pkg/analysis_services/test/completion/completion_computer_test.dart:24:
expect(computers.length, equals(1));
expect(computers, hasLength(1));

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/test/c...
pkg/analysis_services/test/completion/completion_computer_test.dart:41: if
(count != 1) {
Move if (count == 1) return; before constructing the error message?

[danrubel, 2014-07-31 16:07:24]

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_completion.dart:56: Response
processRequest(Request request) {
On 2014/07/30 22:44:24, scheglov wrote:
> `completion.getSuggestions`

Done.

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/completion/top_level_computer.dart (right):

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/top_level_computer.dart:10: import
'package:analysis_services/completion/completion_computer.dart';
On 2014/07/30 22:44:24, scheglov wrote:
> Use Cmd+1  |  Sort unit/class members :-)

Ah! I like it. Done. Now if only it was a "do this on save" option.... :-)

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/test/c...
File pkg/analysis_services/test/completion/completion_computer_test.dart
(right):

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/test/c...
pkg/analysis_services/test/completion/completion_computer_test.dart:24:
expect(computers.length, equals(1));
On 2014/07/30 22:44:24, scheglov wrote:
> expect(computers, hasLength(1));

Done.

https://codereview.chromium.org/428313002/diff/1/pkg/analysis_services/test/c...
pkg/analysis_services/test/completion/completion_computer_test.dart:41: if
(count != 1) {
On 2014/07/30 22:44:24, scheglov wrote:
> Move if (count == 1) return; before constructing the error message?

Good point. Moved msg construction inside if block.

[danrubel, 2014-07-31 16:11:25]

Committed patchset #4 manually as r38787 (presubmit successful).