Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 428273002: Handle-like interface for HashTable. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Handle-like interface for HashTable. A combination of two independent interface changes: 1. Constructor takes a RawArray* and allocates its own Array handle. 2. Release provides access to the entire handle, rather than just the raw. This results in a very clean usage pattern, like: FooTable table(get_foo_table()); table.Insert(obj); ... set_foo_table(table.Release()); Having the isolate inside HashTable also allows faster allocation of temporary handles. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38794

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -96 lines) Patch
M runtime/vm/hash_table.h View 1 2 3 20 chunks +75 lines, -47 lines 0 comments Download
M runtime/vm/hash_table_test.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 6 chunks +19 lines, -31 lines 0 comments Download
M runtime/vm/symbols.cc View 1 2 3 3 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 4 months ago (2014-07-30 21:18:16 UTC) #1
Ivan Posva
LGTM -ip https://codereview.chromium.org/428273002/diff/40001/runtime/vm/symbols.cc File runtime/vm/symbols.cc (right): https://codereview.chromium.org/428273002/diff/40001/runtime/vm/symbols.cc#newcode284 runtime/vm/symbols.cc:284: Isolate* cur_isolate = Isolate::Current(); cur_isolate -> isolate
6 years, 4 months ago (2014-07-31 17:45:05 UTC) #2
koda
https://codereview.chromium.org/428273002/diff/40001/runtime/vm/symbols.cc File runtime/vm/symbols.cc (right): https://codereview.chromium.org/428273002/diff/40001/runtime/vm/symbols.cc#newcode284 runtime/vm/symbols.cc:284: Isolate* cur_isolate = Isolate::Current(); On 2014/07/31 17:45:05, Ivan Posva ...
6 years, 4 months ago (2014-07-31 19:49:55 UTC) #3
koda
6 years, 4 months ago (2014-07-31 19:50:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r38794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698