Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 42823002: Avoid watching files that aren't going to change for "pub serve". (Closed)

Created:
7 years, 2 months ago by nweiz
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Avoid watching files that aren't going to change for "pub serve". R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=29229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/watch_sources.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/package_graph.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
This came up when I was working on issue 14428. I noticed that "pub serve" ...
7 years, 2 months ago (2013-10-25 00:59:31 UTC) #1
Alan Knight
lgtm
7 years, 2 months ago (2013-10-25 01:02:41 UTC) #2
nweiz
Committed patchset #1 manually as r29229 (presubmit successful).
7 years, 2 months ago (2013-10-25 01:32:31 UTC) #3
Bob Nystrom
7 years, 1 month ago (2013-10-28 22:32:23 UTC) #4
Message was sent while issue was closed.
LGTM, nice optimization.

Powered by Google App Engine
This is Rietveld 408576698