Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 427853002: Add a hidden --no-package-symlinks flag. (Closed)

Created:
6 years, 4 months ago by nweiz
Modified:
6 years, 4 months ago
Reviewers:
Bob Nystrom, danrubel
CC:
reviews_dartlang.org, danrubel
Visibility:
Public.

Description

Add a hidden --no-package-symlinks flag. This will help the editor test against the no-symlink behavior before we roll it out to the world. BUG=20253 R=danrubel@google.com, rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=38702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -28 lines) Patch
M sdk/lib/_internal/pub/bin/pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command.dart View 4 chunks +14 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 5 chunks +55 lines, -24 lines 0 comments Download
A sdk/lib/_internal/pub/test/no_package_symlinks_test.dart View 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 4 months ago (2014-07-29 18:40:52 UTC) #1
danrubel
lgtm
6 years, 4 months ago (2014-07-29 20:00:47 UTC) #2
Bob Nystrom
lgtm
6 years, 4 months ago (2014-07-29 21:15:27 UTC) #3
nweiz
6 years, 4 months ago (2014-07-29 21:36:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r38702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698