Properly handle "#void" in analysis server.

Properly handle "#void" in analysis server.

Also fix corelib/symbol_reserved_word_test/05, which was incorrectly
marked as a compile-time error.  It should be a static type warning,
since "#void.foo" should be interpreted as "access the 'foo' field of
the 'void' symbol".

BUG=dartbug.com/20191
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38641

[Brian Wilkerson, 2014-07-28 18:09:10]

LGTM

[Paul Berry, 2014-07-28 19:03:11]

Committed patchset #1 manually as r38641 (presubmit successful).

[ahe, 2017-04-05 20:04:14]

https://codereview.chromium.org/427603002/diff/1/tests/corelib/symbol_reserve...
File tests/corelib/symbol_reserved_word_test.dart (right):

https://codereview.chromium.org/427603002/diff/1/tests/corelib/symbol_reserve...
tests/corelib/symbol_reserved_word_test.dart:21: x = #void.foo;               
/// 05: static type warning
What is supposed to happen when this line is executed?

[Paul Berry, 2017-04-05 20:29:29]

https://codereview.chromium.org/427603002/diff/1/tests/corelib/symbol_reserve...
File tests/corelib/symbol_reserved_word_test.dart (right):

https://codereview.chromium.org/427603002/diff/1/tests/corelib/symbol_reserve...
tests/corelib/symbol_reserved_word_test.dart:21: x = #void.foo;               
/// 05: static type warning
On 2017/04/05 20:04:14, ahe wrote:
> What is supposed to happen when this line is executed?

It should be equivalent to:

x = (#void).foo;

So it should produce a runtime error:

NoSuchMethodError: Class 'Symbol' has no instance getter 'foo'.

Gilad was supposed to update the spec so that the grammar rule for symbol would
be:

symbolLiteral:
  ‘#’ (void | operator | (identifier (‘.’ identifier)*))
  ;

But it looks like he never got around to it
(https://github.com/dart-lang/sdk/issues/20191 is still open).

In retrospect I used the wrong test expectation; it should have been:

x = #void.foo; /// 05: runtime error, static type warning

Or maybe this would have been clearer:

x = #void.hashCode; /// 05: ok

[ahe, 2017-04-06 10:55:52]

https://codereview.chromium.org/427603002/diff/1/tests/corelib/symbol_reserve...
File tests/corelib/symbol_reserved_word_test.dart (right):

https://codereview.chromium.org/427603002/diff/1/tests/corelib/symbol_reserve...
tests/corelib/symbol_reserved_word_test.dart:21: x = #void.foo;               
/// 05: static type warning
On 2017/04/05 20:29:28, Paul Berry wrote:
> On 2017/04/05 20:04:14, ahe wrote:
> > What is supposed to happen when this line is executed?
> 
> It should be equivalent to:
> 
> x = (#void).foo;
> 
> So it should produce a runtime error:
> 
> NoSuchMethodError: Class 'Symbol' has no instance getter 'foo'.
> 
> Gilad was supposed to update the spec so that the grammar rule for symbol
would
> be:
> 
> symbolLiteral:
>   ‘#’ (void | operator | (identifier (‘.’ identifier)*))
>   ;
> 
> But it looks like he never got around to it
> (https://github.com/dart-lang/sdk/issues/20191 is still open).
> 
> In retrospect I used the wrong test expectation; it should have been:
> 
> x = #void.foo; /// 05: runtime error, static type warning
> 
> Or maybe this would have been clearer:
> 
> x = #void.hashCode; /// 05: ok

Thank you for the details. Based on them, I've changed it to:

Expect.throws(() { x = #void.foo; }, (e) => e is NoSuchMethodError); //# 05:
static type warning

In CL 2804843003.

[Paul Berry, 2017-04-06 17:20:58]

https://codereview.chromium.org/427603002/diff/1/tests/corelib/symbol_reserve...
File tests/corelib/symbol_reserved_word_test.dart (right):

https://codereview.chromium.org/427603002/diff/1/tests/corelib/symbol_reserve...
tests/corelib/symbol_reserved_word_test.dart:21: x = #void.foo;               
/// 05: static type warning
On 2017/04/06 10:55:52, ahe wrote:
> On 2017/04/05 20:29:28, Paul Berry wrote:
> > On 2017/04/05 20:04:14, ahe wrote:
> > > What is supposed to happen when this line is executed?
> > 
> > It should be equivalent to:
> > 
> > x = (#void).foo;
> > 
> > So it should produce a runtime error:
> > 
> > NoSuchMethodError: Class 'Symbol' has no instance getter 'foo'.
> > 
> > Gilad was supposed to update the spec so that the grammar rule for symbol
> would
> > be:
> > 
> > symbolLiteral:
> >   ‘#’ (void | operator | (identifier (‘.’ identifier)*))
> >   ;
> > 
> > But it looks like he never got around to it
> > (https://github.com/dart-lang/sdk/issues/20191 is still open).
> > 
> > In retrospect I used the wrong test expectation; it should have been:
> > 
> > x = #void.foo; /// 05: runtime error, static type warning
> > 
> > Or maybe this would have been clearer:
> > 
> > x = #void.hashCode; /// 05: ok
> 
> Thank you for the details. Based on them, I've changed it to:
> 
> Expect.throws(() { x = #void.foo; }, (e) => e is NoSuchMethodError); //# 05:
> static type warning
> 
> In CL 2804843003.

Sounds reasonable.  Thanks!