Uncomment and test fixes for importing libraries.

Uncomment and test fixes for importing libraries.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=38637

[Brian Wilkerson, 2014-07-28 18:06:57]

LGTM

https://codereview.chromium.org/427473003/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/correction/util.dart (right):

https://codereview.chromium.org/427473003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/util.dart:73: Map<String, Element>
getExportNamespace2(LibraryElement library) {
How about getExportNamespaceForDirective and getExportNamespaceForLibrary rather
than getExportNamespace and getExportNamespace2?

https://codereview.chromium.org/427473003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/util.dart:358:
CorrectionUtils_InsertDesc get insertDescImport {
These getters look like they could take a while. I think the general philosophy
is that getters should be used only when they are about as fast as a field
access, and that methods should be used when they take longer than that. But I
leave it to you to decide.

[scheglov, 2014-07-28 18:27:28]

https://codereview.chromium.org/427473003/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/correction/util.dart (right):

https://codereview.chromium.org/427473003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/util.dart:73: Map<String, Element>
getExportNamespace2(LibraryElement library) {
On 2014/07/28 18:06:56, Brian Wilkerson wrote:
> How about getExportNamespaceForDirective and getExportNamespaceForLibrary
rather
> than getExportNamespace and getExportNamespace2?

Done.

https://codereview.chromium.org/427473003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/util.dart:358:
CorrectionUtils_InsertDesc get insertDescImport {
On 2014/07/28 18:06:56, Brian Wilkerson wrote:
> These getters look like they could take a while. I think the general
philosophy
> is that getters should be used only when they are about as fast as a field
> access, and that methods should be used when they take longer than that. But I
> leave it to you to decide.

Thank you, fixed.

[scheglov, 2014-07-28 18:28:06]

Committed patchset #1 manually as r38637 (presubmit successful).