Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 426923002: Start running the analysis server integration tests by changing the name to end with _test.dart (Closed)

Created:
6 years, 4 months ago by ricow1
Modified:
6 years, 4 months ago
Reviewers:
Bill Hesse, Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Start running the analysis server integration tests by changing the name to end with _test.dart Note that these will not run on the vm bots, only on the pub/pkg bots on the right. I would rather that we keep this in the normal setup. If we are seeing to long cycle times we should shard these machines instead of special casing. Sorry if you wasted time doing the new specialized test suite. If we want to, we can skip this on specific platforms in the status files(qua comments in mail thread), but I don't think we should I ran this in a loop on my linux box for a few hours, no flakes. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=38661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, -426 lines) Patch
A + pkg/analysis_server/test/integration/analysis_domain_int_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/analysis_server/test/integration/analysis_domain_inttest.dart View 1 chunk +0 lines, -201 lines 0 comments Download
A + pkg/analysis_server/test/integration/analysis_error_int_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/analysis_server/test/integration/analysis_error_inttest.dart View 1 chunk +0 lines, -35 lines 0 comments Download
A + pkg/analysis_server/test/integration/completion_domain_int_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/analysis_server/test/integration/completion_domain_inttest.dart View 1 chunk +0 lines, -57 lines 0 comments Download
A + pkg/analysis_server/test/integration/server_domain_int_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/analysis_server/test/integration/server_domain_inttest.dart View 1 chunk +0 lines, -137 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 4 months ago (2014-07-29 11:04:50 UTC) #1
Bill Hesse
lgtm
6 years, 4 months ago (2014-07-29 11:06:11 UTC) #2
ricow1
Committed patchset #1 manually as r38661 (presubmit successful).
6 years, 4 months ago (2014-07-29 11:11:59 UTC) #3
Paul Berry
6 years, 4 months ago (2014-07-29 13:34:27 UTC) #4
Message was sent while issue was closed.
lgtm.

No worries on the time I spent doing the specialized test suite.  It was a good
way to familiarize myself with the test framework.

Powered by Google App Engine
This is Rietveld 408576698