Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 426793002: Test for the 'importing a package library' fix. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Test for the 'importing a package library' fix. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -48 lines) Patch
M pkg/analysis_services/lib/src/correction/fix.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_services/test/correction/fix_test.dart View 4 chunks +43 lines, -31 lines 0 comments Download
M pkg/analysis_testing/lib/abstract_context.dart View 3 chunks +5 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/source/package_map_resolver.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 6 chunks +46 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 4 months ago (2014-07-28 22:07:16 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-07-28 22:17:16 UTC) #2
scheglov
6 years, 4 months ago (2014-07-28 22:18:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38653 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698