Issue 426243005: Make "server.shutdown" exit the analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 426243005: Make "server.shutdown" exit the analysis server. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make "server.shutdown" exit the analysis server. Also update integration tests so that they use "server.shutdown" to terminate each test. This ensures that repeatedly running integration tests does not cause an accumulation of analysis server temporary files. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38739

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -5 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/channel.dart	View	5 chunks	+32 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/integration_tests.dart	View	4 chunks	+50 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/integration/server_domain_int_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/analysis_server/test/mocks.dart	View	5 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 manually as r38739 (presubmit successful).

6 years, 4 months ago (2014-07-30 17:38:45 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages