Issue 426083004: Remove flag enable_debugger as current debugging code has a very minor influence on unoptimzied cod…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 426083004: Remove flag enable_debugger as current debugging code has a very minor influence on unoptimzied cod… (Closed)

Created:
6 years, 4 months ago by srdjan

Modified:
6 years, 4 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Remove flag enable_debugger as current debugging code has a very minor influence on unoptimzied code performance. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=38737

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+251 lines, -310 lines)			Patch
M	runtime/vm/debugger.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2	3 chunks	+3 lines, -7 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2	6 chunks	+47 lines, -57 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 2	6 chunks	+49 lines, -60 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		6 chunks	+45 lines, -56 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View		6 chunks	+62 lines, -73 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View		6 chunks	+45 lines, -56 lines	0 comments	Download

Total messages: 3 (0 generated)

hausner

LGTM [+turnidge, who might be delighted that stepping and setting breakpoints on local variable assignments ...

6 years, 4 months ago (2014-07-30 05:22:48 UTC) #2

srdjan

6 years, 4 months ago (2014-07-30 16:32:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r38737 (presubmit successful).