Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 426053003: Use source_span rather than source_maps in csslib. (Closed)

Created:
6 years, 4 months ago by nweiz
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use source_span rather than source_maps in csslib. This will release csslib 0.11.0 and html5lib 0.11.0+2. BUG=19930 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38716

Patch Set 1 #

Patch Set 2 : Add CHANGELOG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -140 lines) Patch
A pkg/csslib/CHANGELOG.md View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/csslib/lib/css.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/csslib/lib/parser.dart View 9 chunks +11 lines, -11 lines 0 comments Download
M pkg/csslib/lib/src/messages.dart View 6 chunks +8 lines, -9 lines 0 comments Download
M pkg/csslib/lib/src/token.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/csslib/lib/src/tree.dart View 82 chunks +105 lines, -95 lines 0 comments Download
M pkg/csslib/lib/src/tree_base.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/csslib/lib/src/validate.dart View 1 chunk +4 lines, -11 lines 0 comments Download
M pkg/csslib/lib/visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/csslib/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/third_party/html5lib/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/third_party/html5lib/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
Terry for csslib changes, John for html5lib changes.
6 years, 4 months ago (2014-07-29 19:59:18 UTC) #1
nweiz
Add CHANGELOG
6 years, 4 months ago (2014-07-29 21:15:00 UTC) #2
Siggi Cherem (dart-lang)
lgtm
6 years, 4 months ago (2014-07-29 23:57:38 UTC) #3
nweiz
6 years, 4 months ago (2014-07-30 00:13:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698