Issue 425803009: Better implementation of shutdown timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425803009: Better implementation of shutdown timeout. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Better implementation of shutdown timeout. In addition to being easier to read, Future.timeout() has the advantage that if the future completes before the timeout, there isn't a pending asynchronous event unnecessarily keeping the process alive. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38748

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
	M	pkg/analysis_server/test/integration/integration_tests.dart	View		1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 4 months ago (2014-07-30 20:15:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38748 (presubmit successful).

Expand Messages | Collapse Messages