Issue 425363003: Mark GitExceptions as expected in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425363003: Mark GitExceptions as expected in pub. (Closed)

Created:
6 years, 4 months ago by nweiz

Modified:
6 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark GitExceptions as expected in pub. These exceptions are almost always caused by a legitimate user error (e.g. a nonexistent repository), and as such shouldn't be reported as an unexpected error with the suggestion to use "pub --trace". R=rnystrom@google.com BUG=20278 Committed: https://code.google.com/p/dart/source/detail?r=38750

Patch Set 1 #

Patch Set 2 : Fix missing imports #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/exceptions.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sdk/lib/_internal/pub/lib/src/git.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 4 months ago (2014-07-30 21:09:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r38750 (presubmit successful).

Expand Messages | Collapse Messages