Issue 42433002: port Node.bind to bd0a0591920da9091b326627a46a104a92c7efe7

Issue 42433002: port Node.bind to bd0a0591920da9091b326627a46a104a92c7efe7 (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly

Modified:
7 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

port Node.bind to bd0a0591920da9091b326627a46a104a92c7efe7 the first step to fix https://code.google.com/p/dart/issues/detail?id=13950 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29294

Patch Set 2 : #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+826 lines, -720 lines)			Patch
M	pkg/custom_element/lib/custom_element.dart	View		1 chunk	+0 lines, -21 lines	0 comments	Download
M	pkg/pkg.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/lib/src/instance.dart	View		3 chunks	+3 lines, -6 lines	0 comments	Download
M	pkg/polymer/test/attr_mustache_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/template_binding/lib/src/element.dart	View	1	3 chunks	+41 lines, -6 lines	0 comments	Download
M	pkg/template_binding/lib/src/input_bindings.dart	View	1	9 chunks	+42 lines, -33 lines	0 comments	Download
M	pkg/template_binding/lib/src/input_element.dart	View	1	1 chunk	+9 lines, -10 lines	0 comments	Download
M	pkg/template_binding/lib/src/node.dart	View	1	4 chunks	+26 lines, -34 lines	0 comments	Download
M	pkg/template_binding/lib/src/select_element.dart	View		1 chunk	+8 lines, -6 lines	0 comments	Download
M	pkg/template_binding/lib/src/template.dart	View	1	4 chunks	+21 lines, -18 lines	0 comments	Download
M	pkg/template_binding/lib/src/text.dart	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	pkg/template_binding/lib/src/text_area_element.dart	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	pkg/template_binding/lib/template_binding.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/template_binding/test/custom_element_bindings_test.dart	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
D	pkg/template_binding/test/element_bindings_test.dart	View		1 chunk	+0 lines, -397 lines	1 comment	Download
M	pkg/template_binding/test/node_bindings_test.dart	View	1	7 chunks	+534 lines, -16 lines	0 comments	Download
M	pkg/template_binding/test/template_element_test.dart	View	1	62 chunks	+111 lines, -155 lines	0 comments	Download
M	pkg/template_binding/test/utils.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

https://codereview.chromium.org/42433002/diff/30001/pkg/template_binding/test/element_bindings_test.dart File pkg/template_binding/test/element_bindings_test.dart (left): https://codereview.chromium.org/42433002/diff/30001/pkg/template_binding/test/element_bindings_test.dart#oldcode5 pkg/template_binding/test/element_bindings_test.dart:5: library template_binding.test.element_bindings_test; most of these tests moved into the ...

7 years, 2 months ago (2013-10-25 00:51:41 UTC) #1

Jennifer Messerly

7 years, 1 month ago (2013-10-25 21:39:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29294 (presubmit successful).

Expand Messages | Collapse Messages