Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 424213004: Fix CSP mode of the polymer compiler. Turns out that inline Javascript <script> (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 4 months ago
Reviewers:
ricow1, jakemac, blois
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix CSP mode of the polymer compiler. Turns out that inline Javascript <script> tags are also not allowed (unless you have unsafe-inline). This fixes our build to extract code for those script tags as well. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=38707

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -14 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/polymer/lib/src/build/import_inliner.dart View 1 chunk +11 lines, -5 lines 0 comments Download
M pkg/polymer/lib/src/build/polyfill_injector.dart View 1 chunk +1 line, -4 lines 1 comment Download
M pkg/polymer/test/build/import_inliner_test.dart View 2 chunks +42 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/424213004/diff/1/pkg/polymer/lib/src/build/polyfill_injector.dart File pkg/polymer/lib/src/build/polyfill_injector.dart (left): https://codereview.chromium.org/424213004/diff/1/pkg/polymer/lib/src/build/polyfill_injector.dart#oldcode73 pkg/polymer/lib/src/build/polyfill_injector.dart:73: final csp = options.contentSecurityPolicy ? '.precompiled' : ''; this ...
6 years, 4 months ago (2014-07-29 21:30:54 UTC) #1
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-07-29 21:40:53 UTC) #2
blois
lgtm
6 years, 4 months ago (2014-07-29 21:46:08 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r38707 (presubmit successful).
6 years, 4 months ago (2014-07-29 22:12:19 UTC) #4
ricow1
lgtm https://codereview.chromium.org/424213004/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/424213004/diff/1/tools/testing/dart/test_suite.dart#newcode1346 tools/testing/dart/test_suite.dart:1346: if (configuration['csp']) args.add('--csp'); On 2014/07/29 21:30:54, Siggi Cherem ...
6 years, 4 months ago (2014-07-30 09:15:48 UTC) #5
jakemac
6 years, 4 months ago (2014-07-30 14:29:25 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698