Issue 424063002: Add 'pathPrefix' optional argument to VirtualDirectory constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424063002: Add 'pathPrefix' optional argument to VirtualDirectory constructor. (Closed)

Created:
6 years, 4 months ago by Anders Johnsen

Modified:
6 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add 'pathPrefix' optional argument to VirtualDirectory constructor. By setting the pathPrefix, all incoming requests are expected to have its uri starting with the path. Then, before doing resource lookup, the prefix is trimmed from the path. BUG=https://code.google.com/p/dart/issues/detail?id=17353 R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=38720

Patch Set 1 #

Patch Set 2 : Push version. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -4 lines)			Patch
M	pkg/http_server/lib/src/virtual_directory.dart	View		2 chunks	+27 lines, -3 lines	0 comments	Download
M	pkg/http_server/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http_server/test/virtual_directory_test.dart	View		1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

I'm open for alternative names, but I found pathPrefix the easiest to explain so far.

6 years, 4 months ago (2014-07-29 08:31:29 UTC) #1

Anders Johnsen

6 years, 4 months ago (2014-07-30 06:50:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r38720 (presubmit successful).

Expand Messages | Collapse Messages