Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 423713005: add support for _* versions of the url-like attributes (Closed)

Created:
6 years, 4 months ago by jakemac
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add support for _* versions of the url-like attributes BUG=http://dartbug.com/20299 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38838

Patch Set 1 #

Patch Set 2 : add source span and asset id to log #

Patch Set 3 : Also warn if using an _* attribute with no bindings in the value, as that will not get triggered to… #

Total comments: 2

Patch Set 4 : added tests and shortened link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -11 lines) Patch
M pkg/polymer/lib/src/build/import_inliner.dart View 1 2 3 2 chunks +25 lines, -11 lines 0 comments Download
M pkg/polymer/test/build/import_inliner_test.dart View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jakemac
6 years, 4 months ago (2014-07-31 18:34:23 UTC) #1
Siggi Cherem (dart-lang)
nice - let's add a couple tests in import_inliner (both for the rewrite and for ...
6 years, 4 months ago (2014-07-31 21:27:45 UTC) #2
jakemac
updated https://codereview.chromium.org/423713005/diff/40001/pkg/polymer/lib/src/build/import_inliner.dart File pkg/polymer/lib/src/build/import_inliner.dart (right): https://codereview.chromium.org/423713005/diff/40001/pkg/polymer/lib/src/build/import_inliner.dart#newcode345 pkg/polymer/lib/src/build/import_inliner.dart:345: 'http://www.polymer-project.org/docs/polymer/databinding-compat' On 2014/07/31 21:27:45, Siggi Cherem (dart-lang) wrote: ...
6 years, 4 months ago (2014-08-01 14:24:31 UTC) #3
Siggi Cherem (dart-lang)
lgtm
6 years, 4 months ago (2014-08-01 16:23:42 UTC) #4
jakemac
6 years, 4 months ago (2014-08-01 19:55:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as 38838 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698