Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 423283002: Fix analysis server integration tests on Windows. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, danrubel
Visibility:
Public.

Description

Fix analysis server integration tests on Windows. Platform.script is a URI. To safely convert it to a Windows path we need to use .toFilePath(windows: ...). Previously we used .path, which resulted in passing nonsensical paths to the VM when invoking the analysis server subprocess. BUG=dartbug.com/20252 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=38730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
Rico-- I'm fairly confident this is correct, but since I don't yet have a full ...
6 years, 4 months ago (2014-07-29 23:03:59 UTC) #1
ricow1
LGTM I patched it in on my windows box, it works :-)
6 years, 4 months ago (2014-07-30 09:12:38 UTC) #2
Paul Berry
6 years, 4 months ago (2014-07-30 12:40:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698