Issue 423213005: Reland transformation of async functions.

Issue 423213005: Reland transformation of async functions. (Closed)

Created:
6 years, 4 months ago by Michael Lippautz (Google)

Modified:
6 years, 4 months ago

Reviewers:
iposva, hausner, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reland transformation of async functions. Reland https://codereview.chromium.org/362153002/ Additions: * Fixes for parsing async "keyword". * Further tests. BUG= R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=38715

Patch Set 1 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+463 lines, -38 lines)			Patch
M	runtime/vm/ast.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	6 chunks	+20 lines, -0 lines	1 comment	Download
M	runtime/vm/object.cc	View	5 chunks	+13 lines, -1 line	0 comments	Download
M	runtime/vm/parser.h	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	20 chunks	+256 lines, -11 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	tests/language/async_backwards_compatibility_1_test.dart	View	1 chunk	+8 lines, -14 lines	0 comments	Download
A +	tests/language/async_backwards_compatibility_2_test.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download
A +	tests/language/async_helper_lib.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A	tests/language/async_test.dart	View	1 chunk	+129 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/standalone/issue14236_test.dart	View	Binary file		0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Lippautz (Google)

Main difference is in SkipFunctionPreamble(). I also missed async for function literals in the first ...

6 years, 4 months ago (2014-07-29 23:30:49 UTC) #1

Michael Lippautz (Google)

Committed patchset #1 manually as r38715 (presubmit successful).

6 years, 4 months ago (2014-07-29 23:50:42 UTC) #3

Ivan Posva

6 years, 4 months ago (2014-07-29 23:56:14 UTC) #4

Message was sent while issue was closed.

!LGTM -ip

https://codereview.chromium.org/423213005/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/423213005/diff/20001/runtime/vm/object.h#newc...
runtime/vm/object.h:2070: public BitField<RawFunction::AsyncModifier,
kModifierPos, 2> {};  // NOLINT
There is still a mismatch between the number of bits and the number of states
you need to encode here. Please fix. Iff we need to add more states then we can
add bits.

Expand Messages | Collapse Messages