Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 423143002: Remove package root hack from the analysis server integration testing (Closed)

Created:
6 years, 4 months ago by ricow1
Modified:
6 years, 4 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove package root hack from the analysis server integration testing Use the one provided by Platform instead. Remove suppression from status file BUG=20251 R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=38674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +1 line, -14 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 4 months ago (2014-07-29 15:34:51 UTC) #1
Paul Berry
lgtm
6 years, 4 months ago (2014-07-29 15:35:52 UTC) #2
ricow1
6 years, 4 months ago (2014-07-29 15:38:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698