Fix type-checks for reflective redirection constructors.

Fix type-checks for reflective redirection constructors.

R=ahe@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39058

[ahe, 2014-07-27 09:43:31]

LGTM!

https://codereview.chromium.org/422573004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/422573004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2183: // Redirection
factories must not check their argument types.
I'm having a hard time finding this explicitly stated in the specification. So
could you elaborate on what it is in the specification that leads to this
conclusion? I assume it is implicit and falls out of the rule that describes how
to evaluate a redirecting constructor.

https://codereview.chromium.org/422573004/diff/1/tests/lib/mirrors/redirectin...
File tests/lib/mirrors/redirecting_factory_different_type_test.dart (right):

https://codereview.chromium.org/422573004/diff/1/tests/lib/mirrors/redirectin...
tests/lib/mirrors/redirecting_factory_different_type_test.dart:13: factory
A(String x) = B;
As far as I understood the specification, this is a static warning.

Perhaps you should write:

factory A(
String /// 01: static type warning
 x) = B;

[Johnni Winther, 2014-08-04 06:58:03]

lgtm

https://codereview.chromium.org/422573004/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/422573004/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2183: // Redirection
factories must not check their argument types.
On 2014/07/27 09:43:31, ahe wrote:
> I'm having a hard time finding this explicitly stated in the specification. So
> could you elaborate on what it is in the specification that leads to this
> conclusion? I assume it is implicit and falls out of the rule that describes
how
> to evaluate a redirecting constructor.

It is in the spec, implicitly. I even asked Gilad whether that was the
intention, and surprisingly it was!

[floitsch, 2014-08-08 22:46:36]

https://codereview.chromium.org/422573004/diff/1/tests/lib/mirrors/redirectin...
File tests/lib/mirrors/redirecting_factory_different_type_test.dart (right):

https://codereview.chromium.org/422573004/diff/1/tests/lib/mirrors/redirectin...
tests/lib/mirrors/redirecting_factory_different_type_test.dart:13: factory
A(String x) = B;
On 2014/07/27 09:43:31, ahe wrote:
> As far as I understood the specification, this is a static warning.
> 
> Perhaps you should write:
> 
> factory A(
> String /// 01: static type warning
>  x) = B;

I try to avoid too many mirrors-test, since they are relatively slow, but I
agree that this is better.
Done.

[floitsch, 2014-08-08 22:46:46]

Committed patchset #3 manually as r39058 (presubmit successful).