Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 422423003: incremental step moving completion into services and adding tests (Closed)

Created:
6 years, 4 months ago by danrubel
Modified:
6 years, 4 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

incremental step moving completion into services and adding tests BUG= R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=38728

Patch Set 1 #

Patch Set 2 : remove eclipse prefs #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -40 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 3 chunks +2 lines, -34 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
A pkg/analysis_services/lib/completion/top_level_computer.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A + pkg/analysis_services/test/completion/test_all.dart View 1 chunk +4 lines, -5 lines 0 comments Download
A pkg/analysis_services/test/completion/top_level_computer_test.dart View 1 chunk +77 lines, -0 lines 0 comments Download
M pkg/analysis_services/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 4 months ago (2014-07-29 21:50:27 UTC) #1
Paul Berry
lgtm
6 years, 4 months ago (2014-07-29 21:59:26 UTC) #2
danrubel
6 years, 4 months ago (2014-07-30 12:37:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r38728 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698