Issue 42233002: Fix co19 test expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42233002: Fix co19 test expectations (Closed)

Created:
7 years, 2 months ago by hausner

Modified:
7 years, 1 month ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix co19 test expectations Committed: https://code.google.com/p/dart/source/detail?r=29222

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	tests/co19/co19-co19.status	View	1 chunk	+2 lines, -0 lines	2 comments	Download
M	tests/co19/co19-dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

Committed patchset #1 manually as r29222 (presubmit successful).

7 years, 2 months ago (2013-10-24 22:42:54 UTC) #1

kustermann

https://codereview.chromium.org/42233002/diff/1/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/42233002/diff/1/tests/co19/co19-co19.status#newcode19 tests/co19/co19-co19.status:19: Language/12_Expressions/12_Instance_Creation/2_Const_A09_t03: fail, pass, ok Is this a co19 issue? ...

7 years, 1 month ago (2013-10-25 10:26:32 UTC) #2

hausner

7 years, 1 month ago (2013-10-25 15:53:53 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/42233002/diff/1/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (right):

https://codereview.chromium.org/42233002/diff/1/tests/co19/co19-co19.status#n...
tests/co19/co19-co19.status:19:
Language/12_Expressions/12_Instance_Creation/2_Const_A09_t03: fail, pass, ok
On 2013/10/25 10:26:33, kustermann wrote:
> Is this a co19 issue?
> Could you please add a bug number here?

These tests expect a runtime error but should expect a compile-time error. Bug
will be filed. Thanks for reminding me. Done at r29256.

Expand Messages | Collapse Messages