Avoid linear search for function lookup.

Avoid linear search for function lookup.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39101

[Ivan Posva, 2014-08-06 23:37:39]

LGTM after addressing the issues we discussed.

-Ivan

https://codereview.chromium.org/421913010/diff/80001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/421913010/diff/80001/runtime/vm/object.cc#new...
runtime/vm/object.cc:1938: ClassFunctionsSet
set(HashTables::New<ClassFunctionsSet>(len));
As discussed it seems a bit wasteful to be recreating this hash set repeatedly.

https://codereview.chromium.org/421913010/diff/80001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/421913010/diff/80001/runtime/vm/raw_object.h#...
runtime/vm/raw_object.h:501: RawArray* functions_;
Maybe we should make these two field act as a union once we have iteration for
the infrequent/special cases of lookups.

[koda, 2014-08-11 19:26:51]

https://codereview.chromium.org/421913010/diff/80001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/421913010/diff/80001/runtime/vm/object.cc#new...
runtime/vm/object.cc:1938: ClassFunctionsSet
set(HashTables::New<ClassFunctionsSet>(len));
On 2014/08/06 23:37:39, Ivan Posva wrote:
> As discussed it seems a bit wasteful to be recreating this hash set
repeatedly.

Done.

https://codereview.chromium.org/421913010/diff/80001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/421913010/diff/80001/runtime/vm/raw_object.h#...
runtime/vm/raw_object.h:501: RawArray* functions_;
On 2014/08/06 23:37:39, Ivan Posva wrote:
> Maybe we should make these two field act as a union once we have iteration for
> the infrequent/special cases of lookups.

Added TODO to eliminate code that depends on the order of functions (e.g., vm
service ids), which is the first step.

[koda, 2014-08-11 19:28:05]

Committed patchset #6 manually as r39101 (presubmit successful).