Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 421483002: Remove old frog-style dummy bodies from dart2js native class tests (Closed)

Created:
6 years, 5 months ago by sra1
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Remove old frog-style dummy bodies from dart2js native class tests The dummy bodies have been obsolete since native class aware tree shaking. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=38577

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M tests/compiler/dart2js_native/native_call_arity1_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity3_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_arguments1_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_fields_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_fields_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance4_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_with_dart_methods_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_closure_identity_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_exceptions1_frog_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_library_same_name_used_lib1.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_method_with_keyword_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_null_closure_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_property_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_use_native_name_in_table_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
6 years, 5 months ago (2014-07-25 00:36:57 UTC) #1
Johnni Winther
lgtm https://codereview.chromium.org/421483002/diff/1/tests/compiler/dart2js_native/native_field_invocation3_test.dart File tests/compiler/dart2js_native/native_field_invocation3_test.dart (right): https://codereview.chromium.org/421483002/diff/1/tests/compiler/dart2js_native/native_field_invocation3_test.dart#newcode6 tests/compiler/dart2js_native/native_field_invocation3_test.dart:6: import 'dart:_foreign_helper' show JS; Not needed (yet), right?
6 years, 5 months ago (2014-07-25 06:37:06 UTC) #2
sra1
6 years, 4 months ago (2014-07-25 17:34:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r38577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698