Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 421123005: Update 'search.getTypeHierarchy' to the latest spec. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Update 'search.getTypeHierarchy' to the latest spec. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -281 lines) Patch
M pkg/analysis_server/lib/src/search/search_domain.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/search/type_hierarchy.dart View 3 chunks +88 lines, -75 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 16 chunks +216 lines, -203 lines 0 comments Download
M pkg/analysis_services/lib/constants.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 4 months ago (2014-08-04 22:14:52 UTC) #1
jwren
On 2014/08/04 22:14:52, scheglov wrote: LGTM
6 years, 4 months ago (2014-08-04 22:18:31 UTC) #2
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-04 23:18:00 UTC) #3
scheglov
6 years, 4 months ago (2014-08-04 23:27:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 38885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698