Issue 420553007: updated logging package to accept functions or other non-string objects when logging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420553007: updated logging package to accept functions or other non-string objects when logging (Closed)

Created:
6 years, 5 months ago by jakemac

Modified:
6 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

updated logging package to accept functions or other non-string objects when logging R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38584

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -11 lines)			Patch
M	pkg/logging/README.md	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	pkg/logging/lib/logging.dart	View		2 chunks	+18 lines, -10 lines	0 comments	Download
M	pkg/logging/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/logging/test/logging_test.dart	View		1 chunk	+38 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Siggi Cherem (dart-lang)

let's update the pubspec version, otherwise LGTM

6 years, 5 months ago (2014-07-25 18:15:04 UTC) #2

jakemac

6 years, 5 months ago (2014-07-25 18:35:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r38584 (presubmit successful).