Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 420503003: Add test for issue 20190. (Closed)

Created:
6 years, 5 months ago by srdjan
Modified:
6 years, 5 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
A tests/standalone/int_list_test.dart View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
6 years, 5 months ago (2014-07-24 20:33:47 UTC) #1
hausner
lgtm https://codereview.chromium.org/420503003/diff/20001/tests/standalone/int_list_test.dart File tests/standalone/int_list_test.dart (right): https://codereview.chromium.org/420503003/diff/20001/tests/standalone/int_list_test.dart#newcode19 tests/standalone/int_list_test.dart:19: a = new Int32List(100); I guess except for ...
6 years, 5 months ago (2014-07-24 21:05:45 UTC) #2
srdjan
https://codereview.chromium.org/420503003/diff/20001/tests/standalone/int_list_test.dart File tests/standalone/int_list_test.dart (right): https://codereview.chromium.org/420503003/diff/20001/tests/standalone/int_list_test.dart#newcode19 tests/standalone/int_list_test.dart:19: a = new Int32List(100); On 2014/07/24 21:05:45, hausner wrote: ...
6 years, 5 months ago (2014-07-24 21:26:58 UTC) #3
srdjan
6 years, 5 months ago (2014-07-24 21:28:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r38554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698