Issue 420193006: Mark two tests as Pass, Slow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420193006: Mark two tests as Pass, Slow (Closed)

Created:
6 years, 4 months ago by kustermann

Modified:
6 years, 4 months ago

Reviewers:
ricow1, Bob Nystrom, Bill Hesse

CC:
reviews_dartlang.org, nweiz, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Mark two tests as Pass, Slow R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=38623

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	dart/sdk/lib/_internal/pub/pub.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

This is not ideal, there are more tests with 40-60 seconds. Varies a lot. Probably ...

6 years, 4 months ago (2014-07-28 14:08:09 UTC) #1

kustermann

Committed patchset #1 manually as r38623 (presubmit successful).

6 years, 4 months ago (2014-07-28 14:10:31 UTC) #3

Bob Nystrom

6 years, 4 months ago (2014-07-29 15:31:14 UTC) #4

Message was sent while issue was closed.

LGTM, but agree this isn't ideal.

Due to the nature of these tests, there's not much we can do to make them
faster. Each is a single atomic test, but it's an integration test that uses
both dart2js and barback.

When we get import hooks, that should speed up the load time of transformers,
and that should help here.

Expand Messages | Collapse Messages