Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 420063003: Cache config 'getters' in pub. (Closed)

Created:
6 years, 4 months ago by Anders Johnsen
Modified:
6 years, 4 months ago
Reviewers:
nweiz, Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/sdk.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
This improves startup-time, as e.g. sdk.rootDirectory was computed for every single resource (at least all ...
6 years, 4 months ago (2014-07-30 10:22:56 UTC) #1
nweiz
lgtm Thanks!
6 years, 4 months ago (2014-07-30 18:18:50 UTC) #2
Bob Nystrom
LGTM too!
6 years, 4 months ago (2014-07-30 19:12:44 UTC) #3
Anders Johnsen
6 years, 4 months ago (2014-07-31 06:01:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r38771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698