Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 41983004: Now that Dartium requires a single script tag, it no longer tags inline script (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
Reviewers:
vsm, Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

(this is intended to be submitted together with a dartium change.) Now that Dartium requires a single script tag, it no longer tags inline script tags with their line number, so we don't need the mapping logic in polymer anymore. R=jmesserly@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=29291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -61 lines) Patch
M pkg/polymer/lib/src/loader.dart View 3 chunks +13 lines, -61 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-25 16:40:05 UTC) #1
vsm
lgtm
7 years, 1 month ago (2013-10-25 17:25:53 UTC) #2
Jennifer Messerly
lgtm
7 years, 1 month ago (2013-10-25 17:51:49 UTC) #3
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-25 21:27:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29291 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698