Issue 419683002: Revert r38549, r38552, and r38557.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419683002: Revert r38549, r38552, and r38557. (Closed)

Created:
6 years, 4 months ago by nweiz

Modified:
6 years, 4 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert r38549, r38552, and r38557. It's currently too difficult to include a third party package for it to be worthwhile for this use case. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=38564

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -139 lines)			Patch
M	dart/pkg/pkg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	dart/pkg/pool/CHANGELOG.md	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	dart/pkg/pool/lib/pool.dart	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	dart/pkg/pool/pubspec.yaml	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/pkg/pool/test/pool_test.dart	View	4 chunks	+67 lines, -120 lines	0 comments	Download
M	dart/third_party/pkg/.gitignore	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	deps/all.deps/DEPS	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

6 years, 4 months ago (2014-07-25 00:32:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38564 (presubmit successful).