Issue 418433002: Profiler tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418433002: Profiler tweaks (Closed)

Created:
6 years, 5 months ago by Cutch

Modified:
6 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Profiler tweaks * Rename Script tag to Dart tag. * Respect ignore bit on samples. * Mark samples collected with an exit frame. * Don't give exclusive CPU ticks to top frame on samples collected from an exit frame (because CPU usage is in the native code we've called out to not the function waiting to return). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38522

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -48 lines)			Patch
M	runtime/vm/profiler.h	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/profiler.cc	View	1	3 chunks	+8 lines, -4 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_mips.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/tags.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

6 years, 5 months ago (2014-07-23 21:09:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r38522 (presubmit successful).

Expand Messages | Collapse Messages