Issue 41843003: Second round of deprecation removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 41843003: Second round of deprecation removal. (Closed)

Created:
7 years, 1 month ago by Emily Fortuna

Modified:
7 years, 1 month ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Second round of deprecation removal. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=29275

Patch Set 1 : #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+170 lines, -269 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	9 chunks	+89 lines, -126 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	9 chunks	+72 lines, -124 lines	0 comments	Download
M	tests/html/document_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/mutationobserver_test.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	4 chunks	+7 lines, -0 lines	1 comment	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

All that's left are the ones that should actually be suppressed by reading dom.json (that'll ...

7 years, 1 month ago (2013-10-24 22:46:06 UTC) #1

blois

lgtm, with the exception of openDatabase which needs to remain. https://codereview.chromium.org/41843003/diff/20001/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/41843003/diff/20001/tools/dom/scripts/htmlrenamer.py#newcode164 ...

7 years, 1 month ago (2013-10-24 23:01:20 UTC) #2

Emily Fortuna

7 years, 1 month ago (2013-10-25 19:39:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29275 (presubmit successful).

Expand Messages | Collapse Messages