Support optional (non-named) arguments in constructors for reflection.

Support optional (non-named) arguments in constructors for reflection.

BUG= http://dartbug.com/19635
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38536

[Johnni Winther, 2014-07-24 06:45:51]

lgtm

https://codereview.chromium.org/417693002/diff/20001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/417693002/diff/20001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_mirrors.dart:2171: // TODO(floitsch): what about
optional parameters?
Nit. 'what' -> 'What'.

https://codereview.chromium.org/417693002/diff/20001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_mirrors.dart:2360: new List(_parameterCount);
Remove this.

https://codereview.chromium.org/417693002/diff/20001/tests/lib/mirrors/new_in...
File tests/lib/mirrors/new_instance_optional_arguments_test.dart (right):

https://codereview.chromium.org/417693002/diff/20001/tests/lib/mirrors/new_in...
tests/lib/mirrors/new_instance_optional_arguments_test.dart:64: o =
cm.newInstance(#a0, []).reflectee;
This section is a duplicate of the first.

https://codereview.chromium.org/417693002/diff/20001/tests/lib/mirrors/new_in...
tests/lib/mirrors/new_instance_optional_arguments_test.dart:81: o =
cm.newInstance(#a0, [77]).reflectee;
This section is a duplicate of the second.

https://codereview.chromium.org/417693002/diff/20001/tests/lib/mirrors/new_in...
tests/lib/mirrors/new_instance_optional_arguments_test.dart:107: 
Extra line.

[floitsch, 2014-07-24 09:43:49]

https://codereview.chromium.org/417693002/diff/20001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/417693002/diff/20001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_mirrors.dart:2171: // TODO(floitsch): what about
optional parameters?
On 2014/07/24 06:45:51, Johnni Winther wrote:
> Nit. 'what' -> 'What'.

Done.

https://codereview.chromium.org/417693002/diff/20001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_mirrors.dart:2360: new List(_parameterCount);
On 2014/07/24 06:45:51, Johnni Winther wrote:
> Remove this.

Done.

https://codereview.chromium.org/417693002/diff/20001/tests/lib/mirrors/new_in...
File tests/lib/mirrors/new_instance_optional_arguments_test.dart (right):

https://codereview.chromium.org/417693002/diff/20001/tests/lib/mirrors/new_in...
tests/lib/mirrors/new_instance_optional_arguments_test.dart:64: o =
cm.newInstance(#a0, []).reflectee;
On 2014/07/24 06:45:51, Johnni Winther wrote:
> This section is a duplicate of the first.

Done.

https://codereview.chromium.org/417693002/diff/20001/tests/lib/mirrors/new_in...
tests/lib/mirrors/new_instance_optional_arguments_test.dart:81: o =
cm.newInstance(#a0, [77]).reflectee;
On 2014/07/24 06:45:51, Johnni Winther wrote:
> This section is a duplicate of the second.

Done.

https://codereview.chromium.org/417693002/diff/20001/tests/lib/mirrors/new_in...
tests/lib/mirrors/new_instance_optional_arguments_test.dart:107: 
On 2014/07/24 06:45:51, Johnni Winther wrote:
> Extra line.

Done.

[floitsch, 2014-07-24 09:44:31]

Committed patchset #3 manually as r38536 (presubmit successful).