Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 417093005: - Make sure to be able to deal with unaligned snapshot buffers (Closed)

Created:
6 years, 4 months ago by Ivan Posva
Modified:
6 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Make sure to be able to deal with unaligned snapshot buffers for length and kind. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M runtime/platform/globals.h View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/globals.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.h View 2 chunks +19 lines, -10 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
6 years, 4 months ago (2014-07-30 22:48:12 UTC) #1
srdjan
lgtm
6 years, 4 months ago (2014-07-30 22:51:52 UTC) #2
Ivan Posva
6 years, 4 months ago (2014-07-30 22:52:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38759 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698