Add publishTo to pubspec and use it in pub lish.

Add publishTo to pubspec and use it in pub lish.

RELNOTE=Pubspecs can have a "publishTo" field which is either a URL to
  specify the default server that publishing should use or "none" to
  specify that the package is private and cannot be published.
BUG=https://code.google.com/p/dart/issues/detail?id=20046
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38880

[nweiz, 2014-08-01 01:12:13]

lgtm

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/lish.dart (right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/lish.dart:115: dataError("A private
package cannot be published.");
Consider associating this with the "publishTo" span from the pubspec to make it
clear to users what constitutes a private package.

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:214: /// be published to the default
server.
Document that if this returns a URL, it's guaranteed to be valid.

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:223: _error ('"publishTo" field must
be a string.', span);
Nit: no space after _error.

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
File sdk/lib/_internal/pub/test/lish/force_does_not_publish_if_private_test.dart
(right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
sdk/lib/_internal/pub/test/lish/force_does_not_publish_if_private_test.dart:14:
integration('does not publish if the package is private', () {
How is this different than the other test with the same name?

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
File
sdk/lib/_internal/pub/test/lish/server_arg_overrides_publish_to_url_test.dart
(right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
sdk/lib/_internal/pub/test/lish/server_arg_overrides_publish_to_url_test.dart:12:
integration('preview shows an error if the package is private', () {
Wrong description.

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
File sdk/lib/_internal/pub/test/lish/uses_publish_to_url_test.dart (right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
sdk/lib/_internal/pub/test/lish/uses_publish_to_url_test.dart:12:
integration('preview shows an error if the package is private', () {
Wrong description.

[Bob Nystrom, 2014-08-04 21:16:10]

Committed patchset #2 manually as 38880 (presubmit successful).

[Bob Nystrom, 2014-08-04 21:16:44]

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/lish.dart (right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/lish.dart:115: dataError("A private
package cannot be published.");
On 2014/08/01 01:12:13, nweiz wrote:
> Consider associating this with the "publishTo" span from the pubspec to make
it
> clear to users what constitutes a private package.

Didn't add the span, but did mention "publishTo" in the error message.

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:214: /// be published to the default
server.
On 2014/08/01 01:12:13, nweiz wrote:
> Document that if this returns a URL, it's guaranteed to be valid.

Done.

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:223: _error ('"publishTo" field must
be a string.', span);
On 2014/08/01 01:12:13, nweiz wrote:
> Nit: no space after _error.

Done.

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
File sdk/lib/_internal/pub/test/lish/force_does_not_publish_if_private_test.dart
(right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
sdk/lib/_internal/pub/test/lish/force_does_not_publish_if_private_test.dart:14:
integration('does not publish if the package is private', () {
On 2014/08/01 01:12:13, nweiz wrote:
> How is this different than the other test with the same name?

This one does "--force". Well, it does *now*, at least. :-b

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
File
sdk/lib/_internal/pub/test/lish/server_arg_overrides_publish_to_url_test.dart
(right):

https://codereview.chromium.org/417043005/diff/1/sdk/lib/_internal/pub/test/l...
sdk/lib/_internal/pub/test/lish/server_arg_overrides_publish_to_url_test.dart:12:
integration('preview shows an error if the package is private', () {
On 2014/08/01 01:12:13, nweiz wrote:
> Wrong description.

Done.