Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 416973003: Remove documentation links for repo packages. (Closed)

Created:
6 years, 5 months ago by nweiz
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org, Bob Nystrom, kevmoo, Søren Gjesse
Visibility:
Public.

Description

Remove documentation links for repo packages. pub.dartlang.org will now automatically link to dartdocs.org for packages with no documentation link. BUG= http://dartbug.com/20177, http://dartbug.com/20178, http://dartbug.com/20186 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38551

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M pkg/args/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/args/pubspec.yaml View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/crypto/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/http_server/pubspec.yaml View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/json_rpc_2/pubspec.yaml View 1 chunk +0 lines, -1 line 2 comments Download
M pkg/mutation_observer/pubspec.yaml View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/path/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/path/pubspec.yaml View 1 chunk +1 line, -2 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 5 months ago (2014-07-24 19:37:02 UTC) #1
kevmoo
DBC https://codereview.chromium.org/416973003/diff/1/pkg/json_rpc_2/pubspec.yaml File pkg/json_rpc_2/pubspec.yaml (right): https://codereview.chromium.org/416973003/diff/1/pkg/json_rpc_2/pubspec.yaml#newcode2 pkg/json_rpc_2/pubspec.yaml:2: version: 0.1.1-dev Could this be released? https://codereview.chromium.org/416973003/diff/1/pkg/path/pubspec.yaml File ...
6 years, 5 months ago (2014-07-24 19:44:42 UTC) #2
Siggi Cherem (dart-lang)
lgtm
6 years, 5 months ago (2014-07-24 19:49:50 UTC) #3
nweiz
https://codereview.chromium.org/416973003/diff/1/pkg/json_rpc_2/pubspec.yaml File pkg/json_rpc_2/pubspec.yaml (right): https://codereview.chromium.org/416973003/diff/1/pkg/json_rpc_2/pubspec.yaml#newcode2 pkg/json_rpc_2/pubspec.yaml:2: version: 0.1.1-dev On 2014/07/24 19:44:41, kevmoo wrote: > Could ...
6 years, 5 months ago (2014-07-24 20:23:42 UTC) #4
nweiz
Committed patchset #1 manually as r38551 (presubmit successful).
6 years, 5 months ago (2014-07-24 20:24:02 UTC) #5
Siggi Cherem (dart-lang)
6 years, 5 months ago (2014-07-24 21:15:30 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/416973003/diff/1/pkg/path/pubspec.yaml
File pkg/path/pubspec.yaml (right):

https://codereview.chromium.org/416973003/diff/1/pkg/path/pubspec.yaml#newcode2
pkg/path/pubspec.yaml:2: version: 1.2.2
On 2014/07/24 20:23:42, nweiz wrote:
> On 2014/07/24 19:44:42, kevmoo wrote:
> > not +1?
> 
> See
>
https://docs.google.com/a/google.com/document/d/1kPhEF8rL53S45SpzboyddKW61EUn...

if I understand correctly - this is because this specific package is already
post 1.0.0, so the appropriate thing to do is to bump the patch number -
pre-1.0.0 we use the build for this because we ran out of digits :)

Powered by Google App Engine
This is Rietveld 408576698