Support typedefs in function signatures.

Support typedefs in function signatures.

BUG= http://dartbug.com/18938
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39750

[karlklose, 2014-08-12 12:47:45]

LGTM.

https://codereview.chromium.org/416643002/diff/20001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart
(right):

https://codereview.chromium.org/416643002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart:158:

Revert this newline.

[floitsch, 2014-08-12 13:03:11]

https://codereview.chromium.org/416643002/diff/20001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart
(right):

https://codereview.chromium.org/416643002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart:158:

On 2014/08/12 12:47:45, karlklose wrote:
> Revert this newline.

Done.

[floitsch, 2014-08-21 20:33:18]

PTAL.

This is not yet finished. It is missing MirrorsUsed treatment. That is, we need
to collect Typedefs that are reachable from function signatures, and we also
shouldn't emit them if they are not there.

What works, though, is the handling, when we have them.
Working example:
===
library lib;
@MirrorsUsed(targets: const ["lib", "Function", "String"])
import 'dart:mirrors';


typedef String foo();
typedef String foo2(int x);

class B {}

class A {
  foo bar(String foo(x, y)) {}
}

main() {
  print(reflectClass(A).declarations[#bar].returnType);
  print(reflectClass(A).declarations[#bar].parameters[0]);
  print(reflectClass(A).declarations[#bar].parameters[0].type);
  reflectType(foo);
}
=== Output:
TypedefMirror on 'foo'
ParameterMirror on 'foo'
FunctionTypeMirror on '(dynamic, dynamic) -> String'

https://codereview.chromium.org/416643002/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart
(right):

https://codereview.chromium.org/416643002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart:78:
(TypedefType typedef) => true);
This should check if the typedef is in the mirrors used, or not. If not, we
should return false.

[floitsch, 2014-09-01 20:34:29]

PTAL.
This should be ready to go in.

https://codereview.chromium.org/416643002/diff/100001/tests/compiler/dart2js/...
File tests/compiler/dart2js/type_representation_test.dart (right):

https://codereview.chromium.org/416643002/diff/100001/tests/compiler/dart2js/...
tests/compiler/dart2js/type_representation_test.dart:171: expect('$int_rep',
int_, true);
Note the additional 'true' to all the tests.

https://codereview.chromium.org/416643002/diff/100001/tests/compiler/dart2js/...
tests/compiler/dart2js/type_representation_test.dart:185: 'typedef:
$Typedef_rep}]',
This is the only test that changed (since it's the only 'typedef').

[karlklose, 2014-09-02 07:35:31]

SLGTM.

https://codereview.chromium.org/416643002/diff/100001/tests/compiler/dart2js/...
File tests/compiler/dart2js/type_representation_test.dart (right):

https://codereview.chromium.org/416643002/diff/100001/tests/compiler/dart2js/...
tests/compiler/dart2js/type_representation_test.dart:49: [bool encodeTypedefName
= false]) {
How about testing eitehr both variants (encoded typedef and not) or only the
typedef variant? Then you could share tests below.

https://codereview.chromium.org/416643002/diff/100001/tests/lib/mirrors/typed...
File tests/lib/mirrors/typedef_in_signature_test.dart (right):

https://codereview.chromium.org/416643002/diff/100001/tests/lib/mirrors/typed...
tests/lib/mirrors/typedef_in_signature_test.dart:24: const
Symbol("test.typedef_in_signature_test"));
Can't you write `#test.typedef_in_signature_test`?

[floitsch, 2014-09-02 15:50:38]

https://codereview.chromium.org/416643002/diff/100001/tests/compiler/dart2js/...
File tests/compiler/dart2js/type_representation_test.dart (right):

https://codereview.chromium.org/416643002/diff/100001/tests/compiler/dart2js/...
tests/compiler/dart2js/type_representation_test.dart:49: [bool encodeTypedefName
= false]) {
On 2014/09/02 07:35:31, karlklose wrote:
> How about testing eitehr both variants (encoded typedef and not) or only the
> typedef variant? Then you could share tests below.

Refactored and added tests.

https://codereview.chromium.org/416643002/diff/100001/tests/lib/mirrors/typed...
File tests/lib/mirrors/typedef_in_signature_test.dart (right):

https://codereview.chromium.org/416643002/diff/100001/tests/lib/mirrors/typed...
tests/lib/mirrors/typedef_in_signature_test.dart:24: const
Symbol("test.typedef_in_signature_test"));
On 2014/09/02 07:35:31, karlklose wrote:
> Can't you write `#test.typedef_in_signature_test`?

Done.

[floitsch, 2014-09-02 15:54:10]

Committed patchset #8 (id:130001) manually as 39750 (presubmit successful).