Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 415873002: Fix some merge issues with using source_span in pub. (Closed)

Created:
6 years, 5 months ago by nweiz
Modified:
6 years, 5 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Fix some merge issues with using source_span in pub. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=38529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M sdk/lib/_internal/pub/lib/src/lock_file.dart View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 5 months ago (2014-07-24 00:22:48 UTC) #1
Alan Knight
lgtm
6 years, 5 months ago (2014-07-24 00:26:37 UTC) #2
nweiz
6 years, 5 months ago (2014-07-24 00:27:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698