Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 415663002: Allow an analysis server response to have both "error" and "result" fields. (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow an analysis server response to have both "error" and "result" fields. Usually this won't happen, but there are rare cases where it might (e.g. an unexpected exception occurs while analyzing a file in response to analysis.getErrors, and some error information has already been successfully computed). So it seems best to allow it in the integration tests. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=38516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 3 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-23 16:58:26 UTC) #1
jwren
On 2014/07/23 16:58:26, Paul Berry wrote: LGTM
6 years, 5 months ago (2014-07-23 17:21:21 UTC) #2
Paul Berry
6 years, 5 months ago (2014-07-23 18:10:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698