Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 415263002: Drop 'errorToJson', use server's AnalysisError. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Drop 'errorToJson', use server's AnalysisError. R=paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -216 lines) Patch
M pkg/analysis_server/lib/src/computer/error.dart View 2 chunks +21 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 6 chunks +25 lines, -48 lines 0 comments Download
M pkg/analysis_server/test/computer/error_test.dart View 3 chunks +102 lines, -60 lines 0 comments Download
D pkg/analysis_server/test/operation/operation_analysis_test.dart View 1 chunk +0 lines, -100 lines 0 comments Download
M pkg/analysis_server/test/operation/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-24 20:17:11 UTC) #1
Paul Berry
lgtm
6 years, 5 months ago (2014-07-24 20:19:59 UTC) #2
scheglov
6 years, 5 months ago (2014-07-24 20:21:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38550 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698